Translate all tests from AlonzoBBODY to Imp test
#5392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
from
5e2f7c4 to
ea37bbe
Compare
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
4 times, most recently
from
0a5a2ae to
fcc4ab0
Compare
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
from
fcc4ab0 to
d6ca7fa
Compare
Contributor
Author
|
This includes the commits from #5404 and will need to be rebased after that's merged |
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
from
d6ca7fa to
05b4f57
Compare
10 tasks
Also abstract the interface for obtaining events from ImpTestM actions
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
from
05b4f57 to
1e32054
Compare
neilmayhew
commented
Dec 8, 2025
Comment on lines
+108
to
+147
| fixup <- asks iteFixup | ||
| txs <- traverse fixup [tx] | ||
| finalState <- get | ||
|
|
||
| failures <- fmap fst . expectLeftDeepExpr =<< tryTxsInBlock txs finalState | ||
| failures `shouldBeExpr` [injectFailure $ PoolMedataHashTooBig poolId hashSize] |
Contributor
Author
There was a problem hiding this comment.
This feels clunky, and doesn't seem like a particularly good test of BBODY failures. Perhaps there's another way to have a BBODY failure without including a failing transaction (beyond the total script size limitation that's tested in Conway).
Contributor
Author
There was a problem hiding this comment.
I added a better BBODY test. We could drop this old one.
neilmayhew
force-pushed
the
nm/4182-AlonzoBBODY-tests
branch
from
22770d9 to
3b450b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Translate all tests from
AlonzoBBODYto Imp testCloses #4182
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).